Trader Fixes#1525
Merged
LocalIdentity merged 14 commits intoDec 14, 2025
Merged
Conversation
Nightblade
reviewed
Nov 5, 2025
| result = result .. "/" .. realm | ||
| end | ||
| result = result .. "/" .. league:gsub(" ", "+") | ||
| local encodedLeague = league:gsub("[^%w%-%.%_%~]", function(c) |
Contributor
There was a problem hiding this comment.
Any reason not to use our existing urlEncode function here?
Contributor
Author
There was a problem hiding this comment.
No reason. Just add gsub(" ", "+").
Nightblade
reviewed
Nov 5, 2025
Comment on lines
81
to
91
| policies[policyName].retryAfter = os.time() + retryAfter | ||
| end | ||
| local ruleNames = {} | ||
| for match in headers["x-rate-limit-rules"]:gmatch("[^,]+") do | ||
| ruleNames[#ruleNames+1] = match:lower() | ||
| local rulesHeader = headers["x-rate-limit-rules"] | ||
| if rulesHeader and rulesHeader ~= "" then | ||
| for match in rulesHeader:gmatch("[^,]+") do | ||
| ruleNames[#ruleNames+1] = match:lower() | ||
| end | ||
| end | ||
| for _, ruleName in pairs(ruleNames) do | ||
| policies[policyName][ruleName] = {} |
Contributor
There was a problem hiding this comment.
Hi, these should be TAB indented (some more near line 249 too).
Wires77
added
pob1
LocalIdentity
approved these changes
Dec 14, 2025
LocalIdentity
merged commit 303be6e
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
github-actions Bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Dec 14, 2025
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Feb 12, 2026
* Apply changes from PathOfBuildingCommunity/PathOfBuilding-PoE2#1525 * Fix file locations and tab indents * Fix merge issues --------- Co-authored-by: fireundubh <fireundubh@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
* Skip callback on errors to prevent incomplete conversions * Normalize API currency keys to lowercase for consistent lookups * Change sort to alphabetical by league ID for predictable order * Add exponential backoff to rate limit retries to prevent infinite loops on 429 errors * Add deduplication set when merging fetched item batches * Use full URL encoding for leagues instead of simple space replacement * Add checks for empty or non-comma-separated x-rate-limit-rules headers * Decrement request counts only once per expired timestamp across rules * Fix trade query complexity error by prioritizing stat filters * Add persistence to socket count query option * Add trade query test suites * Add test case for skipping callback on error * Add test case for exponential backoff on 429 errors * Use ipairs to retain order --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Primary fix
Various fixes made along the way
Test cases
Recommendations